mantle/kola/tests/ignition: don't skip ignitionFailure test #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks a ton for looking at this! It seems like the test may need to be updated for some changes in the qemu builder API? |
sohankunkerkar
force-pushed
the
fix-mantle-test
branch
4 times, most recently
from
c20d91b to
c48f535
Compare
jlebon
reviewed
Jul 13, 2020
sohankunkerkar
force-pushed
the
fix-mantle-test
branch
from
c48f535 to
0bb5284
Compare
jlebon
approved these changes
Jul 13, 2020
sohankunkerkar
force-pushed
the
fix-mantle-test
branch
from
0bb5284 to
f31556d
Compare
sohankunkerkar
force-pushed
the
fix-mantle-test
branch
from
f31556d to
0e34997
Compare
cgwalters
reviewed
Jul 14, 2020
| return <-errchan | ||
| return errors.New("timed out waiting for initramfs error") | ||
| case err := <-errchan: | ||
| if err != nil { |
Member
There was a problem hiding this comment.
This could just be return err but not worth a respin.
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that coreos/ignition-dracut#146 PR has merged, we can leverage this test.