Skip to content

tests: Remove sysusers test that now lives in fedora-coreos-config#1522

Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom
cgwalters:internal-testing
Jun 11, 2020
Merged

tests: Remove sysusers test that now lives in fedora-coreos-config#1522
openshift-merge-robot merged 1 commit intocoreos:masterfrom
cgwalters:internal-testing

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Jun 9, 2020

This is a successor to #1273

Move this test into
coreos/fedora-coreos-config#468
since it's just clearly better as shell, and to increase coverage
of external tests.

@jlebon
Copy link
Member

jlebon commented Jun 9, 2020

From the discussions in #1273, I do think most of these tests would live better in https://github.com/coreos/fedora-coreos-config.

But not against converting to shell script meanwhile until we do that jump.

/approve

cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this pull request Jun 10, 2020
See coreos/coreos-assembler#1522

The idea is our default for new external tests would be this repo.
@cgwalters
Copy link
Member Author

From the discussions in #1273, I do think most of these tests would live better in https://github.com/coreos/fedora-coreos-config.

Mmmm...ok. coreos/fedora-coreos-config#465

cgwalters added a commit to coreos/fedora-coreos-config that referenced this pull request Jun 11, 2020
See coreos/coreos-assembler#1522

The idea is our default for new external tests would be this repo.
This is a successor to coreos#1273

Move this test into
coreos/fedora-coreos-config#468
since it's just clearly better as shell, and to increase coverage
of external tests.
@cgwalters cgwalters changed the title tests: Convert sysusers test to "external test" model tests: Remove sysusers test that now lives in fedora-coreos-config Jun 11, 2020
@cgwalters
Copy link
Member Author

OK updated to just drop the now-merged test.

@jlebon
Copy link
Member

jlebon commented Jun 11, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8326dec into coreos:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants