Add qemu API to stream journal, use it in devshell #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Apr 30, 2020
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
And more code in e.g.
testiso.gocould use it too which can come later.
Oh yes, that'd be great. I'd really like kola testiso to output logs into --output-dir.
cgwalters
force-pushed
the
qemu-journal-api
branch
from
c102739 to
a894ea4
Compare
Member
|
Needs a |
cgwalters
force-pushed
the
qemu-journal-api
branch
from
a894ea4 to
2bbaef6
Compare
Member
|
/lgtm |
This came up in coreos/ignition-dracut#146 and since then we've been doing more "ad hoc unit writing to virtio" in mantle, but let's add a general API that streams the journal. This is just better for what devshell wants - we can more precisely watch for sshd starting. And more code in e.g. `testiso.go` could use it too which can come later. The immediate motivation here is I may add another kola test which could use this.
cgwalters
force-pushed
the
qemu-journal-api
branch
from
2bbaef6 to
5fd9160
Compare
Member
Author
|
Ah I see, an import conflict. Rebased 🏄 |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in coreos/ignition-dracut#146
and since then we've been doing more "ad hoc unit writing to virtio"
in mantle, but let's add a general API that streams the journal.
This is just better for what devshell wants - we can more precisely
watch for sshd starting. And more code in e.g.
testiso.gocoulduse it too which can come later.
The immediate motivation here is I may add another kola test
which could use this.