qemu: Use a single temporary directory #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had separate code cleaning up: - disk snapshots - rendered ignition config - swtpm Since the swtpm code was already always making a directory, just generalize that and use it for everything so we only have one directory to remove. Came out of discussion in coreos#1393
This was referenced Apr 24, 2020
ashcrow
approved these changes
Apr 24, 2020
darkmuggle
approved these changes
Apr 24, 2020
Contributor
darkmuggle
left a comment
darkmuggle
left a comment
There was a problem hiding this comment.
While adding the nbd code, I really wanted to do this, but kept the scope smaller.
Thank you for working on it @cgwalters
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, darkmuggle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
We are seeing issues in our archive stage in the FCOS pipeline. The ultimate error is Possibly related to this PR? |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 27, 2020
FCOS pipeline is seeing `swtpm/` directory in the working dir: coreos#1399 (comment) I didn't reproduce but this should fix it.
Member
Author
openshift-merge-robot
pushed a commit
that referenced
this pull request
Apr 28, 2020
FCOS pipeline is seeing `swtpm/` directory in the working dir: #1399 (comment) I didn't reproduce but this should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had separate code cleaning up:
Since the swtpm code was already always making a directory, just
generalize that and use it for everything so we only have one
directory to remove.
Came out of discussion in
#1393