devshell: Print serial console as status line, dump when interrupted #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tried this out, though the output is a bit messy because it seems like some control characters still get through or something and we get a mix of some newline characters and some not? I'm pretty happy with |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 23, 2020
I ran out of space in `/tmp` today and it turned out I had a whole lot of `/tmp/mantle-qemu` files, including some really big disk images. This is a combination of changes from coreos#1338 and the multipath PR coreos#1296 Basically if we get interrupted by Ctrl-C which is a lot more likely now when qemu isn't owning the serial console from the start, we will leak our tmpfiles. We probably need to install a `SIGINT` handler but that's a whole mess that's avoided if we just let the kernel clean up our resources for us, which is what was happening before the multipath PR (well, at least for files and not the swtpm tmpdir, but that's small). And actually coreos#1380 does install a `SIGINT` handler so someone please review that and we can maybe fix this more after that lands.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 23, 2020
Previously if one had just `cosa build ostree` then `cosa run`, qemu just stalls out confused. (But this would be a bit better with coreos#1380 so someone review that please!)
openshift-merge-robot
pushed a commit
that referenced
this pull request
Apr 24, 2020
Previously if one had just `cosa build ostree` then `cosa run`, qemu just stalls out confused. (But this would be a bit better with #1380 so someone review that please!)
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 24, 2020
I ran out of space in `/tmp` today and it turned out I had a whole lot of `/tmp/mantle-qemu` files, including some really big disk images. This is a combination of changes from coreos#1338 and the multipath PR coreos#1296 Basically if we get interrupted by Ctrl-C which is a lot more likely now when qemu isn't owning the serial console from the start, we will leak our tmpfiles. We probably need to install a `SIGINT` handler but that's a whole mess that's avoided if we just let the kernel clean up our resources for us, which is what was happening before the multipath PR (well, at least for files and not the swtpm tmpdir, but that's small). And actually coreos#1380 does install a `SIGINT` handler so someone please review that and we can maybe fix this more after that lands.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 24, 2020
I ran out of space in `/tmp` today and it turned out I had a whole lot of `/tmp/mantle-qemu` files, including some really big disk images. This is a combination of changes from coreos#1338 and the multipath PR coreos#1296 Basically if we get interrupted by Ctrl-C which is a lot more likely now when qemu isn't owning the serial console from the start, we will leak our tmpfiles. We probably need to install a `SIGINT` handler but that's a whole mess that's avoided if we just let the kernel clean up our resources for us, which is what was happening before the multipath PR (well, at least for files and not the swtpm tmpdir, but that's small). And actually coreos#1380 does install a `SIGINT` handler so someone please review that and we can maybe fix this more after that lands.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Apr 24, 2020
I ran out of space in `/tmp` today and it turned out I had a whole lot of `/tmp/mantle-qemu` files, including some really big disk images. This is a combination of changes from #1338 and the multipath PR #1296 Basically if we get interrupted by Ctrl-C which is a lot more likely now when qemu isn't owning the serial console from the start, we will leak our tmpfiles. We probably need to install a `SIGINT` handler but that's a whole mess that's avoided if we just let the kernel clean up our resources for us, which is what was happening before the multipath PR (well, at least for files and not the swtpm tmpdir, but that's small). And actually #1380 does install a `SIGINT` handler so someone please review that and we can maybe fix this more after that lands.
This is a followup to the previous progress status for coreos#1367 Rather than trying to parse the serial console, just print it as is, except strip control characters/newlines so that it becomes effectively a progress bar. This way, we don't corrupt the terminal, and we don't fill up its history either. And, go a step farther and dump the whole serial console in the case where we get Ctrl-C before a successful login. This aids in debugging.
cgwalters
force-pushed
the
qemu-progress-console
branch
from
3b6ee7e to
c2145ab
Compare
Member
Author
OK, fixed that.
They're a bit entangled in this patch; seemed simpler to fix the bug. |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
Ugh, I swear I fixed the "grub prompt spewed to console" but apparently not... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to the previous progress status for
#1367
Rather than trying to parse the serial console, just print it as
is, except strip control characters/newlines so that it becomes
effectively a progress bar. This way, we don't corrupt the terminal,
and we don't fill up its history either.
And, go a step farther and dump the whole serial console in the
case where we get Ctrl-C before a successful login. This aids
in debugging.