fcos.upgrade.basic: support rebasing to different stream#1352
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Apr 15, 2020
Merged
fcos.upgrade.basic: support rebasing to different stream#1352openshift-merge-robot merged 1 commit intocoreos:masterfrom
openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
Member
Author
|
Requires: #1351 |
Member
Author
|
To be more clear about the goal here: this provides coverage for upgrading from |
jlebon
force-pushed
the
pr/upgrade-testing-rebase
branch
from
a00390e to
659dc89
Compare
lucab
reviewed
Apr 15, 2020
Member
|
trivial review LGTM /approve |
jlebon
force-pushed
the
pr/upgrade-testing-rebase
branch
from
659dc89 to
8097469
Compare
jlebon
force-pushed
the
pr/upgrade-testing-rebase
branch
from
8097469 to
09689c5
Compare
Member
|
/lgtm |
Member
|
/retest |
We allow nodes to switch streams using `rpm-ostree rebase`. Let's make our upgrade test reflect that. One cool thing to note is that the `upgrade-from-current` test does still use Zincati, so this still does some sanity-checking of Zincati on the new stream. This goes together with the previous commit, in which we've added some support for selecting a separate starting stream.
jlebon
force-pushed
the
pr/upgrade-testing-rebase
branch
from
09689c5 to
4f730e2
Compare
Member
Author
|
OK, rebased this now and fixed a bug! |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow nodes to switch streams using
rpm-ostree rebase. Let's makeour upgrade test reflect that. One cool thing to note is that the
upgrade-from-currenttest does still use Zincati, so this still doessome sanity-checking of Zincati on the new stream.
This goes together with the previous commit, in which we've added some
support for selecting a separate starting stream.