mantle: Rework testiso/metal to use new qemu channel API#1307
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Apr 2, 2020
Merged
mantle: Rework testiso/metal to use new qemu channel API#1307openshift-merge-robot merged 1 commit intocoreos:masterfrom
openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
cgwalters
force-pushed
the
testiso-provide-builder
branch
2 times, most recently
from
a580247 to
5513ba8
Compare
Member
Author
|
Rebased 🏄♂️ |
cgwalters
force-pushed
the
testiso-provide-builder
branch
from
5513ba8 to
cfc08a9
Compare
cgwalters
changed the title
cgwalters
force-pushed
the
testiso-provide-builder
branch
from
cfc08a9 to
946151b
Compare
First, add an API for creating channels that give a pipe to the Go side, so we don't need to write to temp files that we then read. Now, I'm still trying to fine-tune the interface between the "metal" API and the more hardcoded "testiso". Tweak things so that the install path supports being provided a builder object, but add an API that creates a default one that mostly just sets up the default max memory. (Also, I stopped trying to special case a lower memory for the legacy install because that's going to go away anyways)
cgwalters
force-pushed
the
testiso-provide-builder
branch
from
946151b to
7208d41
Compare
darkmuggle
approved these changes
Apr 2, 2020
Contributor
darkmuggle
left a comment
darkmuggle
left a comment
There was a problem hiding this comment.
This is pretty slick. I'm a fan of using virtio-serial as a channel.
Contributor
|
/approve LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, darkmuggle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, add an API for creating channels that give a pipe
to the Go side, so we don't need to write to temp files that
we then read.
Now, I'm still trying to fine-tune the interface between the
"metal" API and the more hardcoded "testiso".
Tweak things so that the install path supports being provided
a builder object, but add an API that creates a default one
that mostly just sets up the default max memory.
(Also, I stopped trying to special case a lower memory for
the legacy install because that's going to go away anyways)