Skip to content

Conversation

@cgwalters
Copy link
Member

First, we don't hard require a config, so there's no reason
to force people to pass the empty string if they don't want one.

Second, this is prep for further work on 9p mounts which want
to build up a config and qemu arguments simultaneously.

First, we don't hard require a config, so there's no reason
to force people to pass the empty string if they don't want one.

Second, this is prep for further work on 9p mounts which want
to build up a config and qemu arguments simultaneously.
@jlebon
Copy link
Member

jlebon commented Mar 27, 2020

Yup, makes a lot of sense to me! (This actually came up in a convo I had with @sohankunkerkar yesterday about how to test coreos/ignition#903; we'll want a way to boot a VM without any Ignition config.)

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9552e83 into coreos:master Mar 27, 2020
@cgwalters
Copy link
Member Author

(This actually came up in a convo I had with @sohankunkerkar yesterday about how to test coreos/ignition#903; we'll want a way to boot a VM without any Ignition config.)

To be clear that worked before this too, you just had to pass "" for the config path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants