-
Notifications
You must be signed in to change notification settings - Fork 187
cmdlib: Use -hda/-hdb instead of virtio-scsi incantations #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmdlib: Use -hda/-hdb instead of virtio-scsi incantations #1288
Conversation
Qemu has convenient shorthand CLI arguments to do what we want here. We're explicitly not using virtio because supermin hardcodes `/dev/sda` sadly. Prep for changing this code to use `kola qemuexec`.
569152c to
247e0d0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
unfortunately i think these scsi incantations are needed for s390x and ppc64le :( |
This reverts commit ad728ab because it apparently doesn't work on s390x/ppc64le: coreos#1288 (comment)
|
OK #1292 for now. |
This reverts commit ad728ab because it apparently doesn't work on s390x/ppc64le: #1288 (comment)
Qemu has convenient shorthand CLI arguments to do what we
want here. We're explicitly not using virtio because supermin
hardcodes
/dev/sdasadly.Prep for changing this code to use
kola qemuexec.