kola: Use RpmArch() instead of architecture()

[Prashanth684]

While not a comprehensive fix as suggested here: #1257 (comment)
this helps to unblock kola tests on non x86 arches

[Prashanth684]

/ok-to-test

[cgwalters]

This would also need to move the location of the kolet binary to /usr/lib/kola/x86_64/kolet right?

I'm not opposed to this but...hm, I'm trying to think of simpler fixes.

[cgwalters]

So this is trying to replace some bits that use the Go arch with the RPM architecture. We may need to do that, but my primary goal was to squash the "portage" architecture as that one is the clear "dead weight" here.

[Prashanth684]

This would also need to move the location of the kolet binary to /usr/lib/kola/x86_64/kolet right?

I'm not opposed to this but...hm, I'm trying to think of simpler fixes.

ah...yes...missed that . should we remove this in the Makefile?
GOARCH:=$(shell uname -m) ifeq ($(GOARCH),x86_64) GOARCH=amd64 else ifeq ($(GOARCH),aarch64) GOARCH=arm64 endif

[Prashanth684]

So this is trying to replace some bits that use the Go arch with the RPM architecture. We may need to do that, but my primary goal was to squash the "portage" architecture as that one is the clear "dead weight" here.

Ok...so there are two things..the architecture of the platform, i.e the VM being created and the host architecture itself ? is there an equivalent to Board then ?

[Prashanth684]

@cgwalters any objections to this ?

[cgwalters]

Oh sorry I'd missed that you'd pushed an update to this PR. Looks great to me! The net code reduction was the intent of the original switch.

And in the future I will be sure to ping you guys on code that touches the architecture architecture!

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Prashanth684]

Oh sorry I'd missed that you'd pushed an update to this PR. Looks great to me! The net code reduction was the intent of the original switch.

And in the future I will be sure to ping you guys on code that touches the architecture architecture!

/lgtm

thank you! And no worries. We will be keeping an eye out too.