Add "internal" external tests

Makefile

@@ -72,4 +72,6 @@ install:
 	ln -sf ../lib/coreos-assembler/coreos-assembler $(DESTDIR)$(PREFIX)/bin/
 	ln -sf ../lib/coreos-assembler/cp-reflink $(DESTDIR)$(PREFIX)/bin/
 	ln -sf coreos-assembler $(DESTDIR)$(PREFIX)/bin/cosa
+	install -d $(DESTDIR)$(PREFIX)/lib/coreos-assembler/tests/kola
+	cp -rdf tests/kola/* $(DESTDIR)$(PREFIX)/lib/coreos-assembler/tests/kola
 	cd mantle && $(MAKE) install DESTDIR=$(DESTDIR)

mantle/cmd/kola/kola.go

@@ -172,6 +172,19 @@ func preRun(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
+func registerExternals() error {
+	if err := kola.RegisterExternalTests("/usr/lib/coreos-assembler"); err != nil {
+		return err
+	}
+	for _, d := range runExternals {
+		err := kola.RegisterExternalTests(d)
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
 func runRun(cmd *cobra.Command, args []string) error {
 	var patterns []string
 	if len(args) == 0 {
@@ -186,11 +199,8 @@ func runRun(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	for _, d := range runExternals {
-		err := kola.RegisterExternalTests(d)
-		if err != nil {
-			return err
-		}
+	if err := registerExternals(); err != nil {
+		return err
 	}
 
 	runErr := kola.RunTests(patterns, kolaPlatform, outputDir, !kola.Options.NoTestExitError)
@@ -327,11 +337,8 @@ func writeProps() error {
 }
 
 func runList(cmd *cobra.Command, args []string) error {
-	for _, d := range runExternals {
-		err := kola.RegisterExternalTests(d)
-		if err != nil {
-			return err
-		}
+	if err := registerExternals(); err != nil {
+		return err
 	}
 	var testlist []*item
 	for name, test := range register.Tests {

mantle/kola/harness.go

@@ -471,6 +471,7 @@ func RunUpgradeTests(patterns []string, pltfrm, outputDir string, propagateTestE
 type externalTestMeta struct {
 	Architectures string `json:",architectures,omitempty"`
 	Platforms     string `json:",platforms,omitempty"`
+	Distros       string `json:",distros,omitempty"`
 }
 
 func registerExternalTest(testname, executable, dependencydir, ignition string, meta externalTestMeta) error {
@@ -578,6 +579,11 @@ RequiredBy=multi-user.target
 	} else {
 		t.Platforms = strings.Fields(meta.Platforms)
 	}
+	if strings.HasPrefix(meta.Distros, "!") {
+		t.ExcludeDistros = strings.Fields(meta.Distros[1:])
+	} else {
+		t.Distros = strings.Fields(meta.Distros)
+	}
 
 	register.RegisterTest(t)
 

tests/kola/ignition/systemd/enable-service/README.md

@@ -0,0 +1,7 @@
+enable nfs-server, touch /etc/exports as it doesn't exist by default on Container Linux,
+and touch /var/lib/nfs/etab (https://bugzilla.redhat.com/show_bug.cgi?id=1394395) for RHCOS
+
+FCOS just ships the client (see
+https://github.com/coreos/fedora-coreos-tracker/issues/121).
+Should probably just pick a different unit to test with, though
+testing the NFS workflow is useful for RHCOS.

tests/kola/ignition/systemd/enable-service/config.ign

@@ -0,0 +1,23 @@
+{
+    "ignition": {
+        "version": "3.0.0"
+    },
+    "systemd": {
+        "units": [
+            {
+                "name": "nfs-server.service",
+                "enabled": true
+            }
+        ]
+    },
+    "storage": {
+        "files": [
+            {
+                "path": "/etc/exports"
+            },
+            {
+                "path": "/var/lib/nfs/etab"
+            }
+        ]
+    }
+}

tests/kola/ignition/systemd/enable-service/ignition-systemd-nfs

@@ -0,0 +1,9 @@
+#!/bin/bash
+set -xeuo pipefail
+status="$(systemctl is-active nfs-server.service)"
+if [ "${status}" = "inactive" ]; then
+    echo "nfs-server.service is inactive" 1>&2
+    exit 1
+else
+    echo "nfs-server.service = ${status}"
+fi

tests/kola/ignition/systemd/enable-service/kola.json

@@ -0,0 +1,3 @@
+{
+    "distros": "!fcos"
+}