mantle/sdk: Clean out version.go #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
more-sdk-cleanup-2
branch
from
1abf28a to
acdf47c
Compare
I'm trying to make `mantle/sdk` be a coreos-assembler build metadata + mantle integration point, since that's a lot of the role that it played with Container Linux. Clean out `version.go` in prep for that; only one API call is still used, and we can clean that up in the callers after.
cgwalters
force-pushed
the
more-sdk-cleanup-2
branch
from
acdf47c to
c34e641
Compare
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arithx, cgwalters, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make
mantle/sdkbe a coreos-assembler build metadata + mantleintegration point, since that's a lot of the role that it played
with Container Linux.
Clean out
version.goin prep for that; only one API call isstill used, and we can clean that up in the callers after.