buildroot: support list of spec files to builddep#1154
buildroot: support list of spec files to builddep#1154openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
|
One thing is that if we grow a lot of these "curl stuff from the internets" it harms build reproducibility. Man...this modulemd thing not being parallel installable is a chunk of sand in our CI pipeline, and will also be very annoying if we need to work on both old/new rpm-ostree versions. I'm tentatively OK with this though. |
For rpm-ostree, we keep the canonical spec file upstream. Use that instead of the latest deps of the last release since it's going to be more up to date.
|
ShellCheck appeased! ⬆️
Yeah, it's unfortunate. :( Re. reproducibility, I think it's a legitimate concern, though the build process we have now is already far from reproducible. One idea we've floated around before would be to use lockfiles for cosa itself, though I'm not sure if it's quite worth the complexity. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qemu: Automatically turn off swtpm on !x86_64 here
For rpm-ostree, we keep the canonical spec file upstream. Use that
instead of the latest deps of the last release since it's going to be
more up to date.