Skip to content

buildroot: support list of spec files to builddep#1154

Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom
jlebon:pr/src-spec
Feb 26, 2020
Merged

buildroot: support list of spec files to builddep#1154
openshift-merge-robot merged 1 commit intocoreos:masterfrom
jlebon:pr/src-spec

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Feb 26, 2020

For rpm-ostree, we keep the canonical spec file upstream. Use that
instead of the latest deps of the last release since it's going to be
more up to date.

@cgwalters
Copy link
Member

One thing is that if we grow a lot of these "curl stuff from the internets" it harms build reproducibility.

Man...this modulemd thing not being parallel installable is a chunk of sand in our CI pipeline, and will also be very annoying if we need to work on both old/new rpm-ostree versions.

I'm tentatively OK with this though.

For rpm-ostree, we keep the canonical spec file upstream. Use that
instead of the latest deps of the last release since it's going to be
more up to date.
@jlebon
Copy link
Member Author

jlebon commented Feb 26, 2020

ShellCheck appeased! ⬆️

Man...this modulemd thing not being parallel installable is a chunk of sand in our CI pipeline, and will also be very annoying if we need to work on both old/new rpm-ostree versions.

Yeah, it's unfortunate. :(

Re. reproducibility, I think it's a legitimate concern, though the build process we have now is already far from reproducible. One idea we've floated around before would be to use lockfiles for cosa itself, though I'm not sure if it's quite worth the complexity.

@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fe8a51b into coreos:master Feb 26, 2020
jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
qemu: Automatically turn off swtpm on !x86_64 here
@jlebon jlebon deleted the pr/src-spec branch July 6, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants