buildupload: Don't set Content-Encoding for gzip #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreos#862 (comment) This regressed OpenShift on OpenStack installs, which had adjusted to deal with the lack of `Content-Encoding` and a switch to add `.gz` to images. Basically, if we're going to say things are explicitly compressed, let's not also tell people to *transparently* decompress them because it's easy to end up with a file named `.gz` that was decompressed.
|
lgtm, thanks! |
|
LGTM as well, thank you!! |
miabbott
approved these changes
Dec 18, 2019
Member
miabbott
left a comment
miabbott
left a comment
There was a problem hiding this comment.
LGTM. Probably should backport to 4.3, too
Member
Author
|
CI doesn't cover this, so merging now. |
jlebon
approved these changes
Dec 18, 2019
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Unfortunate, but makes sense. It's weird how complicated all this stuff is. We're trying to be nice and provide more information about the content and it backfires on us.
Member
Author
The original PR isn't on 4.3 AFAICS. |
This was referenced Dec 19, 2019
stbenjam
added a commit
to stbenjam/installer
that referenced
this pull request
Jan 7, 2020
The current version of RHCOS pinned in the installer has a regression in how the gzipped images are handled. This release uses the .gz extension, but also adds a header for transport compression which results in curl producing a decompressed image with a .gz extension that breaks the baremetal platform. This was fixed in coreos/coreos-assembler#1006.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#862 (comment)
This regressed OpenShift on OpenStack installs, which had adjusted
to deal with the lack of
Content-Encodingand a switch to add.gzto images.
Basically, if we're going to say things are explicitly compressed,
let's not also tell people to transparently decompress them because
it's easy to end up with a file named
.gzthat was decompressed.