[WIP] providers/vmware: add an experimental rd-net-kargs #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds initial/experimental support for bootstrapping the network in the initrd. It is meant to support weird cloud providers where DHCP is not available or not usable. This feature is currently reachable as a dedicated `exp rd-net-bootstrap` subcommand. The first provider where this logic is required is `ibmcloud-classic`.
Member
|
In prior discussion we debated whether or not these networking parameters should be "apply once" or be applied every boot. I thought we'd leaned towards "apply once" - which argues for doing this more as part of Ignition, right? But, I guess nothing technically stops us from doing "configure once" stuff in afterburn too, it just blurs the architecture diagrams. |
lucab
force-pushed
the
wip/vmw-backdoor-net
branch
from
fdcc7d1 to
fff7e63
Compare
cgwalters
reviewed
Mar 27, 2020
| Ok(HashMap::new()) | ||
| } | ||
|
|
||
| fn hostname(&self) -> Result<Option<String>> { |
Member
There was a problem hiding this comment.
We can implement this right? See openshift/machine-config-operator#1579
Contributor
Author
There was a problem hiding this comment.
I've replied there. The TLDR is that we can but we shouldn't.
This is for platforms where either:
- network auto-configuration is performed via DHCP and a cloud-channel for the hostname
- network auto-configuration happens via some custom protocol, which includes the hostname
Other cases are owned already by 1) dracut kargs and 2) Ignition.
Contributor
Author
|
Closing this stale WIP in favor of #404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily based on #362 for quicker development.