Skip to content

cargo: update to reqwest 0.10 and new API #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucab merged 5 commits into from
Jan 21, 2020
Merged

cargo: update to reqwest 0.10 and new API #339

lucab merged 5 commits into from
Jan 21, 2020

Conversation

@lucab
Copy link
Contributor

@lucab lucab commented Jan 20, 2020

This updates to reqwest 0.10. The default API is now async, but I simply updated and sticked to the blocking API which is good enough for our usecases.

Closes: #337

@lucab lucab added the dependency Pull requests that update a dependency file label Jan 20, 2020
jlebon
jlebon approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@lucab
Copy link
Contributor Author

lucab commented Jan 20, 2020 •
edited
Loading

@jlebon FYI I plan to merge this tomorrow and publish a new release, before starting to land further networking logic (e.g. #338).

@lucab lucab merged commit a50c52f into coreos:master Jan 21, 2020
@lucab lucab deleted the ups/bump-reqwest branch January 21, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlebon jlebon jlebon approved these changes

Assignees

No one assigned

Labels

dependency Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucab @jlebon