Automatically compact memory #2481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're getting absolutely hammered by systems doing various odd queries. I strongly suspect they are systems trying to get data for ML training. This intense use is slowly causing memory fragmentation in our Ruby on Rails application. This attempts to resolve this by automatically compacting memory periodically. We'll automatically do it after we've served a request AND it's been "enough" time since the last time we compacted memory. This value is controlled by BADGEAPP_GC_COMPACT_MINUTES with the default 120 minutes. Signed-off-by: David A. Wheeler <[email protected]>
This fixes a Rubocop error and improves testing. Signed-off-by: David A. Wheeler <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2481 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 58 +1
Lines 2287 2311 +24
=========================================
+ Hits 2287 2311 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting absolutely hammered by systems doing various odd queries. I strongly suspect they are systems trying to get data for ML training. This intense use is slowly causing memory fragmentation in our Ruby on Rails application.
This attempts to resolve this by automatically compacting memory periodically.
We'll automatically do it
after we've served a request AND it's been "enough" time since the last time we compacted memory. This value is
controlled by BADGEAPP_GC_COMPACT_MINUTES with the default 120 minutes.