Skip Rev+ rules for Satoshi system transactions #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transactions This actually affects tracers only, as the system transaction occur in satoshi.go which doesn’t have any Rev+ logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes as a replacement of #71 which was skipping all the system contract addresses, while this newer PR skip the actual Satoshi system transactions, which are slash, turnRound and deposit functions.
Note: the base of this PR is
fix/state_accessor_last_system_tx_indexingbranch. We used this branch as the base as it has some tracer/api changes that were useful. I suggest after squash merging thefix/state_accessor_last_system_tx_indexing, we change the base of this one, rebase it and them merge it.