CORE-18171: Adjust rest permissions for password change #5402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Fitzpatrick
force-pushed
the
tomf/CORE-18171/adjust-rest-permissions-for-password-change
branch
2 times, most recently
from
9d264f8 to
333b963
Compare
|
Jenkins build for PR 5402 build 22 Build Successful: |
|
build e2e PR-402 |
|
Current e2e tests passing here https://ci02.dev.r3.com/job/Corda5/view/Full%20Health%205.2/job/corda5-e2e-tests/job/release%252F5.2/426/ |
vkolomeyko
reviewed
Jan 15, 2024
...e-impl/src/main/kotlin/net/corda/libs/permissions/endpoints/v1/user/impl/UserEndpointImpl.kt
Outdated
Show resolved
Hide resolved
...e-impl/src/main/kotlin/net/corda/libs/permissions/endpoints/v1/user/impl/UserEndpointImpl.kt
Outdated
Show resolved
Hide resolved
libs/rest/rest/src/main/kotlin/net/corda/rest/authorization/AuthorizationUtils.kt
Outdated
Show resolved
Hide resolved
libs/rest/rest-server-impl/src/main/kotlin/net/corda/rest/server/impl/context/ContextUtils.kt
Outdated
Show resolved
Hide resolved
vkolomeyko
previously approved these changes
Jan 16, 2024
… authroization logic Signed-off-by: TomFitzpatrick <[email protected]>
…ties Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
…server-impl Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]> update fix imports Signed-off-by: TomFitzpatrick <[email protected]> detekt Signed-off-by: TomFitzpatrick <[email protected]> detekt Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
…ient Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Tom-Fitzpatrick
force-pushed
the
tomf/CORE-18171/adjust-rest-permissions-for-password-change
branch
from
fe7274b to
0b00e51
Compare
|
Tom-Fitzpatrick
deleted the
tomf/CORE-18171/adjust-rest-permissions-for-password-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an AuthorizationProvider to the RestResource interface. This allows rest resources to provide custom authorization logic for particular routes, by overriding the default method in AuthorizationProvider.
This is used in UserEndpointImpl to ensure that the
changeUserPasswordSelfmethod can always be called by a user, regardless of their permissions.Once this is merged, https://github.com/corda/corda-e2e-tests/pull/402 will enable further e2e tests which cover various permission scenarios.