Fix preferImmediatelyAvailableCredentials usage in iOS package #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ice-tychon
added a commit
to ice-blockchain/ion-app
that referenced
this pull request
Dec 13, 2024
## Description This PR adds a fix for iOS to be able to use another device to login. ## Additional Notes Changes in the passkeys_ios: corbado/flutter-passkeys#83 ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Refactoring - [ ] Documentation - [ ] Chore ## Screenshots <img width="300" alt="image" src="[image_url_here](https://github.com/user-attachments/assets/103e26f1-870e-49d7-b7ab-3b33e077fce5)">
|
Hey Thank you for pointing out the issue. After some trial from my side! It seems that iOS's |
|
I will be merging this PR , also i opened a new one where i added a comment to better explain the reasoning here . Thank you again for suggestion. |
Dopeamin
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes issue with
preferImmediatelyAvailableCredentials.AuthenticateRequestType.allowCredentialsandAuthenticateRequestType.preferImmediatelyAvailableCredentials: falseto thePasskeyAuthenticator().authenticate, but current device doesn't have any of theallowCredentialsthe bevior: