Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interface for DebugLogger to be able to replace the logging me… #337

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Aug 18, 2022

…chanism

This can allow waf.Logger to be replaced by one that logs to Envoy as part of a wasm filter. Or it could even be replaced with a zap implementation that we may provide in the future.

Fixes #330

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.

Make sure that you've checked the boxes below before you submit PR:

Thanks for your PR ❤️

@jptosso jptosso merged commit eeacec6 into corazawaf:v3/dev Aug 18, 2022
@jcchavezs
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants