-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hexDecode transformation #1275
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is taking a nice shape.
Can you extend the json test cases with negative tests?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
+ Coverage 81.76% 81.77% +0.01%
==========================================
Files 169 170 +1
Lines 9770 9777 +7
==========================================
+ Hits 7988 7995 +7
Misses 1533 1533
Partials 249 249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR add a simple implementation of hexDecode function.
Changes are based on std lib.
Related to the issue #1253.
Json test cases were edited. At first glance it looks incorrect. This one. Look this comment.
If you have any doubts or can explain why this test case has this output, please reject the PR and let me know why this test case is valid.