[CORL-3212]: throw no username included error for sso with url for setting username #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
nick-funk
reviewed
Jan 22, 2025
Comment on lines
+41
to
+59
| const parseUsernameNotProvidedError = ( | ||
| error: RRNLRequestError | ||
| ): UsernameNotProvidedErrorObj | null => { | ||
| if (!error.res || error.res.status !== 403 || !error.res.text) { | ||
| return null; | ||
| } | ||
|
|
||
| try { | ||
| const json = JSON.parse(error.res.text) as UsernameNotProvidedErrorObj; | ||
| if (!json || !json.error || json.error.code !== "USERNAME_NOT_PROVIDED") { | ||
| return null; | ||
| } | ||
|
|
||
| return json; | ||
| } catch { | ||
| return null; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
heh, looks like we're going to have to be generalizing this at some point... so many error object types popping up to be parsed through the response text 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes make it so that if an sso token does not include a username for a user, but does include a url for account management to set a username, a helpful error will be thrown letting the user know how to set their username to be able to comment.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can use multi site test to send through an sso user who does not have a username set but does have a url for account management. You should see that
Were any tests migrated to React Testing Library?
How do we deploy this PR?