Support for sendInitialEvents flag on watches. #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
monktastic
commented
May 28, 2024
monktastic
commented
- Allow user to set sendInitialEvents (supported in k8s 1.28+).
- Parse Error events properly.
- Change HTTP read timeout to infinity, to reduce the chances that the stream gets closed and reopened (possibly with a too-old resourceVersion).
- Add a test for ResourceClient.
vigoo
previously approved these changes
May 29, 2024
monktastic
force-pushed
the
aditpras/sendInitialEvents
branch
from
7b667c7
to
ee3bca6
Compare
monktastic
force-pushed
the
aditpras/sendInitialEvents
branch
2 times, most recently
from
36f0a0b
to
7cceb6f
Compare
- Change HTTP read timeout to infinity, to reduce the chances that the stream gets closed and reopened (possibly with a too-old resourceVersion). - Add a test for ResourceClient.
monktastic
force-pushed
the
aditpras/sendInitialEvents
branch
from
7cceb6f
to
3ebeec1
Compare
vigoo
previously approved these changes
May 30, 2024
|
Hi @vigoo, I don't have permission to merge ("Only those with write access to this repository can merge pull requests."). How should we proceed? |
- Adding a missing case match for ErrorEvent. - Passing parameters that were missed in Resource.scala.
monktastic
force-pushed
the
aditpras/sendInitialEvents
branch
from
6c8e657
to
54bad1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.