Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Solana to v2 and SPL to the latest #3219

Conversation

acheroncrypto
Copy link
Collaborator

Problem

Solana v2 has been out for some time, but we still depend on v1.

Summary of changes

  • Upgrade all Solana dependencies and toolchain to v2
  • Upgrade all SPL dependencies to current latest versions that are compatible with Solana v2
  • Use Pod exported from anchor-lang for get_mint_extension_data because Pod is no longer exported from spl-token-2022
  • max_size parameter of token_group_initialize instruction has been changed to u64 (due to the underyling changes in the Token 2022's initialize_group instruction)
  • Update the setup script to install Solana v2.0.8 and switch to agave-install

Copy link

vercel bot commented Sep 2, 2024

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto
Copy link
Collaborator Author

mpl-token-metadata is not compatible with Solana v2 (metaplex-foundation/mpl-token-metadata#127):

error[E0308]: mismatched types
   --> src/metadata.rs:887:9
    |
886 |     fn id() -> Pubkey {
    |                ------ expected `anchor_lang::prelude::Pubkey` because of return type
887 |         ID
    |         ^^ expected `anchor_lang::prelude::Pubkey`, found `solana_program::pubkey::Pubkey`
    |
    = note: `solana_program::pubkey::Pubkey` and `anchor_lang::prelude::Pubkey` have similar names, but are actually distinct types
note: `solana_program::pubkey::Pubkey` is defined in crate `solana_program`
   --> src/pubkey.rs:88:1
note: `anchor_lang::prelude::Pubkey` is defined in crate `solana_program`
   --> src/pubkey.rs:96:1
    = note: perhaps two different versions of crate `solana_program` are being used?

@acheroncrypto acheroncrypto merged commit 020a304 into coral-xyz:master Sep 17, 2024
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ci cli client dependencies Pull requests that update a dependency file feature lang next Required for the next release spl tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant