Skip to content

Commit

Permalink
Ensures daemon controller manager are stopped during daemon shutdown
Browse files Browse the repository at this point in the history
Tho the daemon manages and starts controllers, they don't seem to be
stopped when the daemon shutsdown which could yield unexpected behavior
or leaks. This PR ensures the associated controllers are stopped
when the daemon shuts down.

Signed-off-by: Fernand Galiana <[email protected]>
  • Loading branch information
derailed authored and julianwiedmann committed Sep 15, 2023
1 parent d2be494 commit 35cbce2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions daemon/cmd/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,7 @@ func (d *Daemon) Close() {
}
identitymanager.RemoveAll()
d.cgroupManager.Close()
d.controllers.RemoveAllAndWait()
}

// TriggerReloadWithoutCompile causes all BPF programs and maps to be reloaded,
Expand Down

0 comments on commit 35cbce2

Please sign in to comment.