Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaker manager for multi-speaker handling #441

Merged
merged 70 commits into from
Apr 27, 2021
Merged

Speaker manager for multi-speaker handling #441

merged 70 commits into from
Apr 27, 2021

Conversation

erogol
Copy link
Member

@erogol erogol commented Apr 21, 2021

  • SpeakerManager to interface multi-speaker models.
  • Use SpeakerManager in Synthesizer
  • Adapt SC-Glow models from @Edresson using SpeakerManager .
  • Tests for SpeakerManager
  • Update demo server to use multi-speaker models.
  • Update synthesize.py to use multi-speaker models.
  • Update training scripts to use SpeakerManager in multi-speaker case.

Enabling multi-speaker models means;

  • Let people list speaker of a multi-speaker model.
  • Choose a certain speaker to generate voice
  • Let people upload voice samples to mimic the multi-speaker model.

To call the multi-speaker models with this PR;

$ tts --model_name tts_models/en/vctk/sc-glow-tts --list_models  # list the available speakers for the model
$ tts --text "This is a multi-speaker model.." --out_path output.wav  --model_name tts_models/en/vctk/sc-glow-tts --speaker_idx 'p333'     # run the model
$ tts-server --model_name tts_models/en/vctk/sc-glow-tts  # run the demo server 

@erogol erogol requested a review from Edresson April 21, 2021 11:22
@erogol erogol added the enhancement General library enhancement. label Apr 21, 2021
Copy link
Contributor

@Edresson Edresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, everything is ok, great addition is much better visually than the old version :)

@erogol erogol requested a review from Edresson April 26, 2021 17:54
@erogol erogol marked this pull request as ready for review April 26, 2021 17:54
@kirianguiller
Copy link
Contributor

Hi @erogol , you had any trouble for including the #5 in it ?

@erogol
Copy link
Member Author

erogol commented Apr 28, 2021

@kirianguiller what do you mean?

I started with your PR. Rebased it and wrote a bunch more :).

@erogol erogol deleted the speaker-manager branch April 28, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General library enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants