-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Stream Generator on MacOS #3792
Closed
gravityrail
wants to merge
187
commits into
coqui-ai:dev
from
gravityrail:fix/macos-stream-generator
Closed
Fix Stream Generator on MacOS #3792
gravityrail
wants to merge
187
commits into
coqui-ai:dev
from
gravityrail:fix/macos-stream-generator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import sorting now handled by ruff.
There is nothing in the repo that would refer to them [ci skip]
CI: remove unused check_skip steps
Lint overhaul (pylint to ruff)
The repository requires Python>=3.9, so this is obsolete.
Already exist as: TTS.tts.layers.vits.stochastic_duration_predictor.DilatedDepthSeparableConv TTS.tts.layers.vits.stochastic_duration_predictor.ElementwiseAffine
torch.range(a, b) == torch.arange(a, b+1) meshgrid indexing: pytorch/pytorch#50276 checkpoint use_reentrant: https://dev-discuss.pytorch.org/t/bc-breaking-update-to-torch-utils-checkpoint-not-passing-in-use-reentrant-flag-will-raise-an-error/1745 optimizer.step() before scheduler.step(): https://pytorch.org/docs/stable/optim.html#how-to-adjust-learning-rate
VC-related refactors and fixes
Made automatically with: rg "from TTS.utils.io import load_fsspec" --files-with-matches | xargs sed -i 's/from TTS.utils.io import load_fsspec/from trainer.io import load_fsspec/g'
All uses of these methods were replaced with the equivalents from coqui-tts-trainer
Update to coqui-tts-trainer 0.1.4
docs(xtts): fix typo in example
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for streaming responses on macOS. It was crashing somewhere in pytorch. Unfortunately I can't find the original post where I found this patch to give credit - too many tabs open! But it works for me.
For this to work, you must run with
PYTORCH_ENABLE_MPS_FALLBACK=1
and callmodel.to(mps_device)
on the XttsModel