fix cache config error #3138
fix cache config error #3138
Conversation
|
|
| config_local = json.load(f) | ||
| try: | ||
| config_local = json.load(f) | ||
| except: |
There was a problem hiding this comment.
A bare except: is not a good idea. For instance, a KeyboardInterrupt will be caught by it.
Instead, catch the particular exception that json.load() would raise for an empty file (json.JSONDecodeError).
There was a problem hiding this comment.
Actually IMO for this case a bare except is exactly what is needed, if you consider what problem this commit is solving.
The problem here is that it completely avoids downloading anything if something went wrong. The worst case scenario here is it re-downloads the files. It doesn't matter what goes wrong during the json.load, if something unexpected happens, it should just redownload the files.
There was a problem hiding this comment.
IT should avoid downloading anything if something is wrong. Even if you download the remaining files, the model most prob would not work. We should debug why the files empty and fix that. Any ideas ?
There was a problem hiding this comment.
A bare except: is never a good idea, though. except Exception: maybe, if you really need to catch everything, but except:, never.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
What does this fix?
Fixes this problem: #3074
What was the problem?
When the TTS library fails to download the config files for some reason (which has been happening very often recently), we end up with
config.json,model.pth,vocab.jsonfiles that are empty (0 bytes).When this happens, the
json.load(f)line fails and it doesn't even reach the next line where it comparesconfig_localwithconfig_remote.This is made worse by the exception handler at https://github.com/cocktailpeanut/TTS/blob/33c95daa55808817b67e5bf66c68134889059c15/TTS/utils/manage.py#L402 NOT handling the error and calling
pass.To fix this, I've added the
try/exceptclause, and if the try fails it sets theconfig_localto None and at least moves to the next line and compares withconfig_remote, at which point it should correctly recognize that they are different and retry the download.