Package rocq-pil.1.0.0 #3341
Open
Package rocq-pil.1.0.0 #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silene
reviewed
Feb 18, 2025
Comment on lines
+40
to
+42
| "category:CS/Algo/Decision procedures" | ||
| "category:Math/Logic/Foundations" | ||
| "category:Math/Logic/Modal Logic" |
There was a problem hiding this comment.
Suggested change
| "category:CS/Algo/Decision procedures" | |
| "category:Math/Logic/Foundations" | |
| "category:Math/Logic/Modal Logic" | |
| "category:Computer Science/Decision Procedures and Certified Algorithms/Decision procedures" | |
| "category:Mathematics/Logic/Foundations" | |
| "category:Mathematics/Logic/Modal logic" |
| ] | ||
|
|
||
| build: [ | ||
| [make "-j%{jobs}%"] |
There was a problem hiding this comment.
Does this actually work? Given that the first target of the Makefile only invokes coq_makefile, I would assume that no Coq files were actually compiled here. (But I did not try.)
proux01
reviewed
Feb 18, 2025
|
|
||
| depends: [ | ||
| "dune" {>= "3.8"} | ||
| "coq" {>= "8.20.1"} |
There was a problem hiding this comment.
Since it depends from Coq, the package name should be coq-pil, not rocq-pil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocq-pil.1.0.0Rocq library for Propositional Intuitionistic Logic & Pitts Interpolation Library
🐫 Pull-request generated by opam-publish v2.5.0