Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce 'ci_cron_schedule' for scheduled CI actions #97

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

chdoc
Copy link
Member

@chdoc chdoc commented Apr 11, 2021

This enables scheduled runs for actions-based CI via a new variable called ci_cron_schedule. As discussed in #77, there is no default value to keep everyone from using the same value.

closes: #77

@chdoc chdoc requested review from Zimmi48 and erikmd April 11, 2021 13:13
Copy link
Member

@erikmd erikmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chdoc.

Three small suggestions/questions:

@chdoc
Copy link
Member Author

chdoc commented Apr 12, 2021

could you mention the implied timezone? (according to https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onschedule, it's UTC)

done!

are you sure that when writing '{{ ci_cron_schedule }}' in the mustache file, it won't add an extra quoting? (didn't test right now)

If I add ci_cron_schedule: '5 4 * * *' to my meta.yml, the diff I get is:

on:
+  schedule:
+    - cron: '5 4 * * *'
   push:

So I think the quoting is as it should be.

would it be worth it, to add in the description, a remark like this? "Also, projects may prefer different intervals, such as daily or weekly builds."

I commented the examples to explain that one of them is weekly while the other is daily.

Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Zimmi48 Zimmi48 merged commit ad871ac into master Apr 13, 2021
@Zimmi48 Zimmi48 deleted the cron_schedule branch April 13, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding support for nighty and weekly builds for CI based on GitHub actions
3 participants