Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround example to support NodeJS less V10.11.0 and even less V8.13.0 #443

Closed
wants to merge 3 commits into from
Closed

workaround example to support NodeJS less V10.11.0 and even less V8.13.0 #443

wants to merge 3 commits into from

Conversation

proxy-m
Copy link
Contributor

@proxy-m proxy-m commented Apr 13, 2021

See commits, it just working example.

@proxy-m proxy-m closed this Apr 13, 2021
@proxy-m proxy-m deleted the master-node8 branch April 13, 2021 12:44
@proxy-m proxy-m restored the master-node8 branch April 13, 2021 12:45
@proxy-m proxy-m reopened this Apr 13, 2021
@@ -83,7 +83,7 @@ CORE_FILES=const.js config.js io.js main.js lib.js ide.js pci.js floppy.js \
cpu.js debug.js \
elf.js kernel.js
LIB_FILES=9p.js filesystem.js jor1k.js marshall.js utf8.js
BROWSER_FILES=screen.js keyboard.js mouse.js speaker.js serial.js \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue with speaker.js?

Copy link
Contributor Author

@proxy-m proxy-m Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like version problem of Closure compiller, or Nodejs, or Reflect:

src/browser/speaker.js:487: ERROR - [JSC_UNDEFINED_VARIABLE] variable AudioWorkletProcessor is undeclared
            var self = Reflect.construct(AudioWorkletProcessor, [], DACProcessor);
                                         ^^^^^^^^^^^^^^^^^^^^^

src/browser/speaker.js:766: ERROR - [JSC_UNDEFINED_VARIABLE] variable AudioWorkletNode is undeclared
        this.node_processor = new AudioWorkletNode(this.audio_context, "dac-processor",
                                  ^^^^^^^^^^^^^^^^

2 error(s), 0 warning(s)
Makefile:100: recipe for target 'build/v86_all.js' failed

Similar compatibility problems links (I tried to search solution, but do not understand):

https://stackoverflow.com/questions/37787606/google-closure-compiler-gives-jsc-inexistent-property-for-new-web-audio-api-meth

https://developers.google.com/closure/compiler/docs/api-tutorial3#howto-app

github/babel-plugin-transform-custom-element-classes#8

https://stackoverflow.com/questions/50346328/what-is-javascript-reflect-construct-newtarget-doing
https://stackoverflow.com/questions/48341824/nodejs-what-does-reflect-function-do
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect (must be supported compatible by table)

https://developer.mozilla.org/en-US/docs/Web/API/AudioWorkletProcessor
emscripten-core/emscripten#6230 (may be similar problem with optimization options, uglifying, es6, context, modules, exporting in conjunction with wasm and closure)

https://stackoverflow.com/questions/36363849/error-when-compiling-code-with-google-closure-compiler (other error about needing externs file)
https://stackoverflow.com/questions/49971779/error-audioworkletnode-is-undefined-in-react-app (other error about react)

https://github.com/teppeis/closure-compiler-es-compat-table/blob/master/es6/latest/syntax/new.target/in_constructors/error.txt

google/closure-compiler#2899

https://kangax.github.io/compat-table/es6/ (errors table)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not priority.

@proxy-m proxy-m closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants