Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose added #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docker-compose added #8

wants to merge 1 commit into from

Conversation

LMtx
Copy link

@LMtx LMtx commented Aug 2, 2018

docker-compose.yml added and README updated

@coppit
Copy link
Owner

coppit commented Aug 13, 2018

I'm not familiar with docker-compose. Will people need to download the yaml file before being able to run docker-compose? The standalone docker command doesn't require anything like that.

Also, I just added the ability to run the docker command with -e args instead of using the config file. So would we create an empty env_file, and reference that from the yaml? (Since the env vars are optional.)

@LMtx
Copy link
Author

LMtx commented Aug 13, 2018

Hello,

Docker compose installation is as easy as this:

pip install docker-compose

Details are described here: https://docs.docker.com/compose/install/

docker-compose needs to be executed in directory where docker-compose.yml is located (so yes, people will need to download this file).

One of great benefits of docker-compose is that you can put all configuration options into that yml file and just execute docker-compose up without any additional arguments which is very convenient.

If you are using Docker then I strongly recommend checking out docker-compose because that is a great tool (especially to manage multi-container setups).

Greetings

@demaniak
Copy link

I would suggest perhaps add the compose file as an example - so that somebody that WANTS to run this with compose has something they can copy and adjust to suite their needs.

But add it as separate instructions - thereby keeping the main running instructions as low level and zero dependency as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants