Skip to content

refactor: facilitate integration from copilot.lua #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

refactor: facilitate integration from copilot.lua #53

merged 2 commits into from
Sep 19, 2025

Conversation

AntoineGS
Copy link
Contributor

@AntoineGS AntoineGS commented Sep 2, 2025 •
edited
Loading

PR 2 or 3

@AntoineGS AntoineGS mentioned this pull request Sep 2, 2025
Closed
@AntoineGS AntoineGS force-pushed the copilotlua_integration branch 2 times, most recently from 9f86f0d to 1c3b631 Compare September 6, 2025 01:43
@tris203
Copy link
Collaborator

tris203 commented Sep 6, 2025

I don't really understand the API wrapper. Why can't we just use the functions directly?

It seems unnecessary

@AntoineGS
Copy link
Contributor Author

I'm fine either way but after spending a few months maintaining copilot.lua I have often wished there was another level of redirection for others to use. That way the implementation can move as much as we want without breaking external users since you would only redirect the function in api.lua to ensure compatibility. It also centralizes/documents the various integration points.

@AntoineGS AntoineGS force-pushed the copilotlua_integration branch from 1c3b631 to c89ca7e Compare September 12, 2025 00:04
@AntoineGS AntoineGS marked this pull request as ready for review September 12, 2025 00:08
@AntoineGS
Copy link
Contributor Author

Not sure why stylua is complaining, I suspect some sort of encoding issue but I have not been able to resolve it :(

PS: The copilot.lua code is ready to merge once this is merged!

tris203
tris203 requested changes Sep 12, 2025
View reviewed changes
@AntoineGS AntoineGS force-pushed the copilotlua_integration branch 2 times, most recently from 9e0d39f to 9dbd77d Compare September 12, 2025 17:10
@AntoineGS
Copy link
Contributor Author

No worries I moved it to copilot.lua as to keep an abstraction between the two!

tris203
tris203 previously approved these changes Sep 13, 2025
View reviewed changes
@tris203 tris203 mentioned this pull request Sep 13, 2025
Closed
@AntoineGS AntoineGS mentioned this pull request Sep 14, 2025
Merged
@Xuyuanp Xuyuanp mentioned this pull request Sep 15, 2025
Open
@AntoineGS
Copy link
Contributor Author

Just checking in, in case you were waiting on something from me before merging :P

Xuyuanp
Xuyuanp reviewed Sep 17, 2025
View reviewed changes
@AntoineGS AntoineGS force-pushed the copilotlua_integration branch from 9dbd77d to 7b51032 Compare September 18, 2025 18:54
@AntoineGS
Copy link
Contributor Author

done!

@Xuyuanp Xuyuanp merged commit 5030766 into copilotlsp-nvim:main Sep 19, 2025
9 checks passed
@AntoineGS AntoineGS deleted the copilotlua_integration branch September 20, 2025 00:06
@AntoineGS
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuyuanp Xuyuanp Xuyuanp left review comments

@tris203 tris203 tris203 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AntoineGS @tris203 @Xuyuanp