Skip to content

Conversation

Xuyuanp
Copy link
Contributor

@Xuyuanp Xuyuanp commented Apr 30, 2025

image

Related Xuyuanp/nes.nvim#6

Close #29

@Xuyuanp Xuyuanp force-pushed the feat/support-inline-edit-display branch from efe7640 to a6a4f3f Compare April 30, 2025 15:01
@Xuyuanp Xuyuanp changed the title feat(ui): inline edit feat(ui): inline edit preview May 1, 2025
@Xuyuanp Xuyuanp force-pushed the feat/support-inline-edit-display branch from 450eae2 to be0415b Compare May 3, 2025 09:30
@Xuyuanp Xuyuanp marked this pull request as ready for review May 3, 2025 09:46
@Xuyuanp Xuyuanp requested a review from tris203 May 3, 2025 09:46
@tris203
Copy link
Collaborator

tris203 commented May 4, 2025

image
image

i seem to still be getting larger diffs on this branch, would you not expect this diff to be more minimal?

@Xuyuanp
Copy link
Contributor Author

Xuyuanp commented May 6, 2025

From what I've seen, Copilot currently seems to only return whole-line edits (like insert, delete, replace), not the real inline edits. But the structure returned by copilotInlineEdit itself can support inline edits. It's possible that the copilot will start send inline edits in the future. This PR handles it. What I am not sure about is whether we need to convert the single-line editing to inline editing.

At the same time, I am also refactoring my plugin (nes.nvim) to implement the copilotInlineEdit method and support inline edits

tris203
tris203 previously approved these changes May 7, 2025
Copy link
Collaborator

@tris203 tris203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have removed the UI tests, then we need to also remove the screenshots from the folder

@tris203 tris203 mentioned this pull request May 7, 2025
@Xuyuanp Xuyuanp force-pushed the feat/support-inline-edit-display branch from be0415b to 9cdb7af Compare May 8, 2025 01:57
@Xuyuanp Xuyuanp merged commit a45b3d9 into main May 16, 2025
9 checks passed
@Xuyuanp Xuyuanp deleted the feat/support-inline-edit-display branch May 16, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: More readable diff view of suggestions
2 participants