feat: add custom-agent reasoning effort - #157
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8e0ca78a-95e9-4e85-a4e9-e68ebdbbd0c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8e0ca78a-95e9-4e85-a4e9-e68ebdbbd0c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8e0ca78a-95e9-4e85-a4e9-e68ebdbbd0c7
Contributor
There was a problem hiding this comment.
Pull request overview
Adds per-custom-agent reasoning effort support to the Clojure Copilot SDK (matching upstream PR #1981), ensuring the new option is spec’d, serialized correctly onto the wire for both session creation and resume, and documented—while also syncing the project version to 1.0.7.0.
Changes:
- Added
:agent-reasoning-effortto custom-agent specs and API surface, with allowed values"low"|"medium"|"high"|"xhigh". - Centralized custom-agent wire serialization for
session.createandsession.resume, emittingreasoningEffortonly when set. - Updated docs/changelog and bumped the library version to
1.0.7.0, plus added integration coverage for wire shape + omission behavior.
Show a summary per file
| File | Description |
|---|---|
| test/github/copilot_sdk/integration_test.clj | Adds integration tests for custom-agent reasoning effort spec validity, wire emission on create/resume, and omission when unset. |
| src/github/copilot_sdk/specs.clj | Introduces ::agent-reasoning-effort and ::reasoning-effort spec; wires the new key into ::custom-agent. |
| src/github/copilot_sdk/client.clj | Adds custom-agent->wire and uses it in both create and resume param builders to emit reasoningEffort. |
| resources/github/copilot_sdk/api_surface.edn | Extends the API surface allowlist to include agent-reasoning-effort. |
| README.md | Updates Maven dependency version example to 1.0.7.0. |
| doc/reference/API.md | Documents :agent-reasoning-effort and its wire behavior in the public API reference. |
| doc/getting-started.md | Updates dependency snippet to 1.0.7.0. |
| doc/api/getting-started.html | Updates rendered HTML docs to 1.0.7.0. |
| doc/api/API.html | Updates rendered HTML API docs with :agent-reasoning-effort and an example. |
| CHANGELOG.md | Adds an [Unreleased] entry for per-custom-agent reasoning effort (post-v1.0.7 sync). |
| build.clj | Bumps project version to 1.0.7.0. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-custom-agent reasoning effort in parity with upstream PR #1981 and syncs the Clojure SDK version to
1.0.7.0.Design
:agent-reasoning-effort, consistent with the existing:agent-modelnaming convention, while emitting the exact upstreamreasoningEffortwire field.Validation
list-sessionstimeout passed on isolated retry1.0.7.0JAR built successfullyReview
[Unreleased]; release-section finalization remains with the maintainer