Skip to content

feat: add custom-agent reasoning effort - #157

Merged
krukow merged 3 commits into
mainfrom
krukow-sync-upstream-sdk
Jul 18, 2026
Merged

feat: add custom-agent reasoning effort#157
krukow merged 3 commits into
mainfrom
krukow-sync-upstream-sdk

Conversation

@krukow

@krukow krukow commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Generated via Copilot on behalf of @krukow

Adds per-custom-agent reasoning effort in parity with upstream PR #1981 and syncs the Clojure SDK version to 1.0.7.0.

Design

  • Uses :agent-reasoning-effort, consistent with the existing :agent-model naming convention, while emitting the exact upstream reasoningEffort wire field.
  • Shares custom-agent serialization across session create and resume so both paths remain wire-compatible.
  • Omits the field when unset; the backend chooses its default rather than inheriting the parent session effort.

Validation

  • Integration suite: 344 tests, 1,673 assertions, zero failures or errors
  • Full E2E suite: 415 tests and 2,299 assertions; one live list-sessions timeout passed on isolated retry
  • All examples passed
  • Documentation validation passed
  • 1.0.7.0 JAR built successfully

Review

Reviewer Finding Decision
Claude Opus 4.8 No code defects; release-hygiene follow-up Feature documented under [Unreleased]; release-section finalization remains with the maintainer
GPT-5.5 No findings No action

krukow added 3 commits July 18, 2026 12:09
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8e0ca78a-95e9-4e85-a4e9-e68ebdbbd0c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8e0ca78a-95e9-4e85-a4e9-e68ebdbbd0c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8e0ca78a-95e9-4e85-a4e9-e68ebdbbd0c7
Copilot AI review requested due to automatic review settings July 18, 2026 10:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-custom-agent reasoning effort support to the Clojure Copilot SDK (matching upstream PR #1981), ensuring the new option is spec’d, serialized correctly onto the wire for both session creation and resume, and documented—while also syncing the project version to 1.0.7.0.

Changes:

  • Added :agent-reasoning-effort to custom-agent specs and API surface, with allowed values "low"|"medium"|"high"|"xhigh".
  • Centralized custom-agent wire serialization for session.create and session.resume, emitting reasoningEffort only when set.
  • Updated docs/changelog and bumped the library version to 1.0.7.0, plus added integration coverage for wire shape + omission behavior.
Show a summary per file
File Description
test/github/copilot_sdk/integration_test.clj Adds integration tests for custom-agent reasoning effort spec validity, wire emission on create/resume, and omission when unset.
src/github/copilot_sdk/specs.clj Introduces ::agent-reasoning-effort and ::reasoning-effort spec; wires the new key into ::custom-agent.
src/github/copilot_sdk/client.clj Adds custom-agent->wire and uses it in both create and resume param builders to emit reasoningEffort.
resources/github/copilot_sdk/api_surface.edn Extends the API surface allowlist to include agent-reasoning-effort.
README.md Updates Maven dependency version example to 1.0.7.0.
doc/reference/API.md Documents :agent-reasoning-effort and its wire behavior in the public API reference.
doc/getting-started.md Updates dependency snippet to 1.0.7.0.
doc/api/getting-started.html Updates rendered HTML docs to 1.0.7.0.
doc/api/API.html Updates rendered HTML API docs with :agent-reasoning-effort and an example.
CHANGELOG.md Adds an [Unreleased] entry for per-custom-agent reasoning effort (post-v1.0.7 sync).
build.clj Bumps project version to 1.0.7.0.

Review details

  • Files reviewed: 11/11 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread src/github/copilot_sdk/client.clj

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 11/11 changed files
  • Comments generated: 0 new
  • Review effort level: Low

@krukow
krukow merged commit eed2973 into main Jul 18, 2026
3 checks passed
@krukow
krukow deleted the krukow-sync-upstream-sdk branch July 18, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants