fix: skip tasks in pretend mode #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
- Coverage 96.66% 96.28% -0.39%
==========================================
Files 42 42
Lines 3122 3201 +79
==========================================
+ Hits 3018 3082 +64
- Misses 104 119 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yajo
reviewed
Feb 21, 2023
yajo
reviewed
Mar 11, 2023
yajo
approved these changes
Mar 21, 2023
|
Absolutely! 😆 I've added the type hints and also improved the formatting a bit 😉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copier now skips tasks execution in pretend mode as discussed in #950. I've extended the fix to also skip migration tasks in pretend mode although they weren't explicitly mentioned in #950, but I think that is consistent behavior.
Fixes #950.