Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --skip option is ignored #966

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Conversation

tgaugry
Copy link
Contributor

@tgaugry tgaugry commented Feb 13, 2023

Command line option "--skip" currently does not work and is just ignored, because its value is not passed to Worker class.

@sisp
Copy link
Member

sisp commented Feb 13, 2023

A test that captures this bug would be great. 🙏

@yajo yajo added the bug label Feb 14, 2023
@yajo yajo added this to the Soon milestone Feb 14, 2023
@yajo
Copy link
Member

yajo commented Feb 14, 2023

Incredible that this passwd unnoticed for so long! Would you mind adding the test please? Thanks!

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #966 (2c98527) into master (2201d02) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
+ Coverage   96.62%   96.69%   +0.06%     
==========================================
  Files          42       42              
  Lines        3111     3142      +31     
==========================================
+ Hits         3006     3038      +32     
+ Misses        105      104       -1     
Flag Coverage Δ
unittests 96.69% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
copier/cli.py 97.59% <ø> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_copy.py 100.00% <0.00%> (ø)
copier/main.py 94.45% <0.00%> (+0.05%) ⬆️
copier/user_data.py 94.93% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tgaugry
Copy link
Contributor Author

tgaugry commented Feb 16, 2023

Hello, could you relaunch the test workflow ? Thanks

@yajo yajo enabled auto-merge (squash) February 17, 2023 19:14
@yajo yajo merged commit 468b9ff into copier-org:master Feb 17, 2023
@tgaugry tgaugry deleted the tgaugry-patch-1 branch February 21, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants