feat: add support for dynamic choices #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisp
force-pushed
the
feat/dynamic-choices
branch
from
bbd6b59 to
e0e2275
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1804 +/- ##
==========================================
- Coverage 97.78% 97.61% -0.17%
==========================================
Files 49 49
Lines 5108 5126 +18
==========================================
+ Hits 4995 5004 +9
- Misses 113 122 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Codecov is hanging for some reason 🤔. |
|
Ah, codecov... using superpowers then. |
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for dynamic choices by allowing a templated string value for the
choiceskey that renders as valid YAML. All choice styles are supported. See also https://github.com/orgs/copier-org/discussions/1193#discussioncomment-10040365.Resolves #1193 #1212 #1359 #1746.