Provide more clarification in error message

[mitchnegus]

This provides more information via the error message when a copy/update operation fails due to potentially unsafe actions. It suggests that a user may want to use the --trust flag for templates that they trust.

[sisp]

Thanks for the PR, @mitchnegus! 🙏

You'll need to update the error message assertions in tests/test_unsafe.py to make the test suite pass. Other than that, it looks good. 👍

[yajo]

Please fix the tests. Thanks!

[codecov]

Codecov Report

Merging #1280 (5b2724f) into master (cc49bdc) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   97.01%   96.96%   -0.05%     
==========================================
  Files          48       48              
  Lines        4053     4053              
==========================================
- Hits         3932     3930       -2     
- Misses        121      123       +2     

Flag	Coverage Δ
unittests	96.96% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
copier/errors.py	91.11% <100.00%> (ø)
tests/test_unsafe.py	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[mitchnegus]

Sorry, I was away from my computer for a week and just got back to checking (didn't notice that this hadn't passed before).

All the tests should be fixed now.

[sisp]

LGTM, @mitchnegus! 👍 Would you mind applying @yajo's requested change still? I'll merge afterwards.

[mitchnegus]

LGTM, @mitchnegus! 👍 Would you mind applying @yajo's requested change still? I'll merge afterwards.

All set—I thought he was just referencing the broken tests and missed the period he had suggested. Should be good to go :)

[sisp]

Perfect 👌, thanks again! 🙇

[sisp]

Ah, it seems @yajo still needs to approve as he requested that one change.