-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding '--skip-answered' flag to enhance user interaction during copier update #1276
feat: Adding '--skip-answered' flag to enhance user interaction during copier update #1276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
+ Coverage 96.95% 97.12% +0.16%
==========================================
Files 47 48 +1
Lines 3969 4238 +269
==========================================
+ Hits 3848 4116 +268
- Misses 121 122 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks perfect to me. Just a minor non-blocking comment. Thanks for this contribution!
It seems you still have a little style issue... if you can run pre-commit it'll fix it for you.
Co-authored-by: Jairo Llopis <[email protected]>
I've fixed your suggested changes.
Any ideas? And another question: how long will it take to deploy in the brew after merging my changes? |
You will have to run Next release will still take some weeks. I don't want to release while on holidays. 🏖 |
Yeah, I see. Pushed new changes. |
@yajo Hey man! |
Since this is a new feature, I'd want to hand-test it before merge, so this will take a bit more than usual due to holidays. Maybe 1 or 2 weeks. But for now you can relax. According to the code, it seems perfect, so I'll just merge when I can give it a try. Otherwise I'll post what to change. Thanks! |
This Pull Request addresses a usability issue troubling users when they run 'copier update'. Previously, each time 'copier update' was run, the user had to review all responses given in the answers file. This was a repetitive and laborious process, particularly for users dealing with extensive templates.
This PR introduces a new flag- --skip-answered to improve the user experience and reduce friction during updates. The new flag allows users to bypass the review of questions already answered in the past. It automatically pulls responses from the answers file and presents only the newly added template questions to the user for their review.
skip-answered
will skip all answered questions and ask user input only for new inputs if they are present.Issue: #1178