Implement snackbar visibility events #191
Conversation
rvasseur31
changed the title
rvasseur31
changed the title
There was a problem hiding this comment.
Great code @rvasseur31, thanks for this well-documented enhancement. I will merge this when I can.
Until then, folks can use this right now via your fork as you recommended on another issue -- in package.json:
"react-native-snackbar": "rvasseur31/react-native-snackbar#feature/callbacks"
|
Hey, @cooperka can you please take a look at this? |
| @@ -37,7 +39,7 @@ @interface RNSnackBarView () { | |||
| @implementation RNSnackBarView | |||
|
|
|||
| + (void)initialize { | |||
| DEFAULT_DURATIONS = @{@"-1" : @1500, @"-2" : @2750, @"0" : @INT_MAX}; | |||
| DEFAULT_DURATIONS = @{@"-1" : @1500, @"0" : @2750, @"-2" : @INT_MAX}; | |||
There was a problem hiding this comment.
note to self: this changed, not worth reverting
|
i badly want to keep this library updated, but i don't currently develop react-native applications on a regular basis, so it's a lot of work to keep my dev environment in working order... new laptop, nothing works. i'm going to ship this code (untested) as a new version; if anything breaks folks can always revert their version & submit a PR to fix it. it's very easy to merge things like that. thanks again for the contribution, @rvasseur31! |
|
released in v2.7.0 🎉 |
Thank you for your time for merging this. |
Implement events with snackbar visibility.
It's a native feature on android : https://stackoverflow.com/a/33076569