Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make numberOfLines optional #174

Merged
merged 3 commits into from
Dec 22, 2020
Merged

Make numberOfLines optional #174

merged 3 commits into from
Dec 22, 2020

Conversation

AliRezaBeigy
Copy link
Contributor

No description provided.

Copy link
Owner

@cooperka cooperka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the type fixes @AliRezaBeigy! One question.

src/index.js Outdated
@@ -107,7 +107,7 @@ const SnackBar: ISnackBar = {
warnDeprecation(options, 'color', 'textColor');

const text = options.text || options.title;
const { numberOfLines } = options;
const { numberOfLines = 2 } = options;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? It seems to default in the native code instead, perhaps we can leave this undefined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, it's unnecessary, handled on this line and this line

@cooperka cooperka merged commit dc507d6 into cooperka:main Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants