Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing max numberOfLines #171

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Allow customizing max numberOfLines #171

merged 2 commits into from
Dec 17, 2020

Conversation

valdio
Copy link
Contributor

@valdio valdio commented Dec 9, 2020

Fix for issue #110

iOS Android
ezgif com-gif-maker ezgif com-gif-maker (1)

@valdio
Copy link
Contributor Author

valdio commented Dec 15, 2020

Hi @cooperka 👋
Thanks for this awesome implementation of the mobile snackbars.

If you don't mind can you please review my PR? 🙏
I really would like to have this feature integrated into the library.

@cooperka cooperka changed the title Snackbar ellipsizes text after 2 lines Allow customizing max numberOfLines Dec 17, 2020
@cooperka
Copy link
Owner

Thank you @valdio! Great PR, I just split out the upgrades into f6b3efd which was merged separately (to keep the PR diff cleaner and more readable).

Tested and verified on Android, untested on iOS. Will release shortly.

@cooperka cooperka merged commit dd47016 into cooperka:master Dec 17, 2020
@cooperka cooperka mentioned this pull request Dec 17, 2020
Closed
@rkbhochalya rkbhochalya mentioned this pull request Jan 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valdio @cooperka