Enable title coloring #101
Conversation
The $FlowFixMe for processColor is no longer necessary because it is now properly typed in react-native. Additionally, disabling the no-param-reassign eslint rule is easily avoided, so this resolves that as well. This shouldn't result in any behavioral changes.
The `color` option is processed the same way as the other color params and is then passed down to the native implementations where it can be used to style the snackbar's title text.
getView and findViewById were called multiple times, unnecessarily. This change should not result in any behavior changes.
|
This looks great @thomasw, thank you. If I have time to make equivalent changes to iOS this week I will, otherwise I'll merge as-is and note that it's Android-only in the readme. Cheers. |
|
Sweet 👍 As you can see from those test failures, some of the changes which I claimed didn't result in behavior changes actually did result in at least a subtle one. On Android, the implementation behaves the same when given a config containing keys with their values set to undefined vs. a config with undefined keys. I'm assuming the same would be true for the iOS side, but it's definitely something we'll want to verify. |
This might not actually be true. These changes cause an exception when a snackbar is invoked with an undefined action. I'll dig a little deeper as soon as I have time to come back to this. |
|
Not sure if this is the right way to do this, but I made a PR to merge iOS title color support into thomas' fork. I tested it; works well in my app. I can't speak to the test failure situation, but hopefully you guys can incorporate these changes. Thanks! |
|
Thanks, everyone! 🎆 |
Related #47
This enables changing the snackbar title color on Android, which is likely a requirement if your app's theme defines a dark value for
textColor(doing so overrides the default white color of the title and sets its color totextColor).This pull request does not yet include the equivalent changes for iOS, which I'm unable to work on and verify at the moment. I'm opening this for visibility so someone can take it the rest of the way if they come across it before I have the chance.