-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crystal port #60
Merged
Merged
Crystal port #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added -i flag to install youtube-dl, ffmpeg, and ffprobe
Updated to v1.0.0
Moved more permanent variables to the config. I need to start thinking about custom configs rather than a hard-coded one.
If the general search doesn't return a playlist, it will bootstrap your terms into a specific call for the user's playlists and search through them
- updated cli for config viewing and changes - updated config method. an environment variable `IRS_CONFIG_LOCATION` will be set pointing to a yaml file with a config - moved album metadata changing from a janky homebrew json modifier to the core json lib - mapper.cr is the collection of classes for messing around with json metadata - playlists are almost done, they still need the ability to (optionally) change the metadata of the songs downloaded in the playlist, but they (optionally) will place all downloaded playlist songs in a single folder - added a getter to the filename in song.cr
- changed license to MIT - wrote out actual README - spotify client keys are checked for on run in config.cr - spotify-searcher class doesn't crash now when there's a problem with the keys or authentication, rather it just sets @authenticated to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything has been converted to crystal-lang. It's beautiful