This repository was archived by the owner on May 29, 2018. It is now read-only.
Remove user checking from invitation show#79
Merged
enricostano merged 1 commit intodevelopfrom Feb 22, 2016
Merged
Conversation
Contributor
|
More than delegating to UI the issue here is that the 👍 |
Contributor
Author
|
Can we merge this? I suppose Travis is not ready. Right? |
enricostano
added a commit
that referenced
this pull request
Feb 22, 2016
…-on-invitation-show Remove user checking from invitation show
enricostano
deleted the
fix/remove-current-user-checking-on-invitation-show
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WAT
I removed user checking on
invitation#showend point. This was raising this issue #78Finally I decided that is not API responsibility in this case if there is in the UI a user logged. Is better delegate that check to UI application.
I'm doing that in this front end PR: coopdevs/katuma-web#9
Thoughts?