Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom network aliases for interconnectivity of services deployed with rolling release with Dockerfile, Docker Image and Nixpacks #4741

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

piotr-woojcik
Copy link

@piotr-woojcik piotr-woojcik commented Jan 5, 2025

Changes

  • Column and Form input for custom network aliases for Dockerfile and Docker image apps
  • Appending existing custom network aliases to image name in generate_compose_file()
  • Tested with rolling update also

Feature request #1910

configuration
containers_inspect
network_inspect
pings

Copy link

sentry-io bot commented Jan 5, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/Jobs/ApplicationDeploymentJob.php

Function Unhandled Issue
App\Jobs\ApplicationDeploymentJob::generate_compose_file ErrorException: Undefined variable $labels /app/J...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@the-leonat
Copy link

the-leonat commented Jan 6, 2025

thanks for making this pull request. could the functionality be expanded to Nixpacks easily? It seems input fields for network-aliases are only shown when Dockerfile or Docker-Compose build strategies are selected.

@gschurck
Copy link

gschurck commented Jan 6, 2025

This is a must-have feature !
Will it work with rolling release ?

@piotr-woojcik
Copy link
Author

This is a must-have feature ! Will it work with rolling release ?

hi, it works with rolling release. It's field in db table and append your custom aliases to aliases on creating app compose during deployment

@piotr-woojcik
Copy link
Author

thanks for making this pull request. could the functionality be expanded to Nixpacks easily? It seems input fields for network-aliases are only shown when Dockerfile or Docker-Compose build strategies are selected.

hi, I believe it will work but I've added form input just for this two options do you have and open repo that works with Nixpacks so I could test that feature also? (I'll try to find one also)

@piotr-woojcik
Copy link
Author

I've just added that feature also for other deployments except compose and swarm, tested Nixpacks with simple go server repo.

@acgfbr
Copy link

acgfbr commented Jan 10, 2025

i need this asap

@the-leonat
Copy link

can we push the visibility of this feature some how? As already stated in #1910, this is a must have for all people deploying interconnected services with zero-downtime guarantees.

@piotr-woojcik
Copy link
Author

can we push the visibility of this feature some how? As already stated in #1910, this is a must have for all people deploying interconnected services with zero-downtime guarantees.

we have to wait for merge from main contributors to "next" branch and then wait for update of "main". Wait for this or contact with them if you want to make it faster.

If you want this now you can build my fork on server with branch from this pull request however I assume you know what that will cause.

@piotr-woojcik piotr-woojcik changed the title Custom network aliases for Dockerfile and Docker Image apps Custom network aliases for interconnectivity of services deployed with rolling release with Dockerfile, Docker Image and Nixpacks Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants