Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 step deletion #4007

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix 2 step deletion #4007

merged 2 commits into from
Oct 25, 2024

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Oct 24, 2024 •
edited
Loading

Changes

  • Fix: Password is now checked if 2-step confirmation is enabled (bug introduced on next, so no effect on current version).
  • Fix: 2-step confirmation now checks for password before disabling.

@peaklabs-dev peaklabs-dev added the 🏔️ Peaklabs A label for PRs that are ready for review/merge and have been created by Peaklabs. label Oct 24, 2024
@peaklabs-dev peaklabs-dev marked this pull request as ready for review October 24, 2024 14:23
@andrasbacsai
Copy link
Member

Thank you for the PR!

@andrasbacsai andrasbacsai merged commit cb9b485 into next Oct 25, 2024
4 checks passed
@github-actions github-actions bot removed 🏔️ Peaklabs A label for PRs that are ready for review/merge and have been created by Peaklabs. labels Oct 25, 2024
@peaklabs-dev peaklabs-dev deleted the fix-2-step-deletion branch October 25, 2024 09:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peaklabs-dev @andrasbacsai