Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next #3832

Merged
merged 79 commits into from
Oct 10, 2024
Merged

Next #3832

merged 79 commits into from
Oct 10, 2024

Conversation

peaklabs-dev
Copy link
Member

No description provided.

peaklabs-dev and others added 25 commits October 8, 2024 22:11
fix: duplicate domain error
fix: remove fqdn constraint from db, because it is checked on app level
Feat: New services and service fixes part 2
Improve `service-templates.json` file readability
remove mautic 4 because if it out of support
@peaklabs-dev peaklabs-dev marked this pull request as ready for review October 10, 2024 11:27
Copy link

gitguardian bot commented Oct 10, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14098696 Triggered Generic Password e1bcae7 templates/compose/resend.yaml View secret
14098696 Triggered Generic Password 8095453 templates/compose/resend.yaml View secret
14098696 Triggered Generic Password aa2e170 templates/compose/resend.yaml View secret
14100542 Triggered Generic Password 77b3a3f templates/compose/owncloud.yaml View secret
14100542 Triggered Generic Password 5d7d717 templates/compose/owncloud.yaml View secret
14100542 Triggered Generic Password 7da6b01 templates/compose/owncloud.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@peaklabs-dev peaklabs-dev merged commit f9b5475 into new-services-3 Oct 10, 2024
2 of 3 checks passed
andrasbacsai added a commit that referenced this pull request Oct 10, 2024
Merge pull request #3832 from coollabsio/next
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.